rdrand: allow(unused_unsafe) when calling __cpuid#770
Merged
Conversation
This is currently a release blocker: #769
Merged
newpavlov
approved these changes
Dec 27, 2025
takumi-earth
pushed a commit
to earthlings-dev/getrandom
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently a release blocker: #769
NOTE: this must've been a very recent change, as it's still marked
unsafeonbeta: https://doc.rust-lang.org/beta/core/arch/x86_64/fn.__cpuid.htmlHowever, it's safe on
nightly: https://doc.rust-lang.org/nightly/core/arch/x86_64/fn.__cpuid.htmlI can add a comment similar to the one earlier in the file where there's anotherallow(unused_unsafe)if that helps:// TODO(MSRV 1.94): remove allow(unused_unsafe) and the unsafe block.Edit: added TODO in 558282a